maint: update macos image for building wheels#27
Merged
oscarbenjamin merged 1 commit intoflintlib:masterfrom Dec 6, 2022
Merged
maint: update macos image for building wheels#27oscarbenjamin merged 1 commit intoflintlib:masterfrom
oscarbenjamin merged 1 commit intoflintlib:masterfrom
Conversation
Collaborator
Author
|
I tested the wheel for Python 3.10 on OSX 12.0.1 and it seems to work fine. This also removes the last warning from GitHub Actions CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS-10.15 image is deprecated. It looks like numpy uses macos-12 to build their wheels so I went with that:
https://github.com/numpy/numpy/blob/297c66131f2a32ebb7dfb0aeb9d88d917a791430/.github/workflows/wheels.yml#L78
I'll download and test the wheels before merging.